• Clemens Hammacher's avatar
    [wasm] Remove strong reference in TopTierCompiledCallback · 368bf36e
    Clemens Hammacher authored
    Registered callbacks should not keep the NativeModule alive. Otherwise,
    tiering will always run to completion, even if the NativeModule is not
    being used any more.
    This change can cause the callback to not be called if the module dies
    before it finishes top-tier compilation. This is the desired behaviour.
    
    R=ahaas@chromium.org
    CC=titzer@chromium.org, bbudge@chromium.org
    
    Bug: v8:8689, chromium:719172
    Change-Id: Ide9d639f465497c3ed3439c7ce25c76dceeb97eb
    Reviewed-on: https://chromium-review.googlesource.com/c/1435937Reviewed-by: 's avatarBill Budge <bbudge@chromium.org>
    Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#59175}
    368bf36e
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...