• bmeurer's avatar
    Revert of Externalize deoptimization reasons. (patchset #7 id:120001 of... · 368a503c
    bmeurer authored
    Revert of Externalize deoptimization reasons. (patchset #7 id:120001 of https://codereview.chromium.org/874323003/)
    
    Reason for revert:
    This CL breaks RelocInfo::INTERNAL_REFERENCE (and maybe others that come after DEOPT_REASON), which is currently (mostly) unused on tip-of-tree, but will be used for jump tables soon(ish) and should therefore work. It seems to be a problem with implicitly assumptions about the number of reloc info modes. Needs further investigation.
    
    Original issue's description:
    > Externalize deoptimization reasons.
    >
    > 1) The hardcoded strings were converted into DeoptReason enum.
    >
    > 2) Deopt comment were converted into a pair location and deopt reason entries so
    > the deopt reason tracking mode would less affect the size of the RelocInfo table and heap.
    >
    > 3) DeoptReason entry in RelocInfo reuses kCommentTag value and generates short entry in RelocInfo table.
    >
    > BUG=452067
    > LOG=n
    >
    > Committed: https://crrev.com/c49820e45b57f128a98690940875c049f612dde6
    > Cr-Commit-Position: refs/heads/master@{#26434}
    >
    > Committed: https://crrev.com/ec42e002da03adb2db968dd5b7453341ddc59a5c
    > Cr-Commit-Position: refs/heads/master@{#26448}
    
    TBR=alph@chromium.org,mstarzinger@chromium.org,svenpanne@chromium.org,yurys@chromium.org,loislo@chromium.org
    NOPRESUBMIT=true
    NOTREECHECKS=true
    NOTRY=true
    BUG=452067
    
    Review URL: https://codereview.chromium.org/900223002
    
    Cr-Commit-Position: refs/heads/master@{#26457}
    368a503c
Name
Last commit
Last update
benchmarks Loading commit data...
build Loading commit data...
include Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
Makefile.nacl Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...