• Benedikt Meurer's avatar
    [turbofan] Remove unsound SeqString types. · 36426ab7
    Benedikt Meurer authored
    A value of type OtherSeqString can change its type to OtherNonSeqString
    via inplace internalization (and redirection via a ThinString). This can
    lead to out of bounds memory accesses and generally correctness bugs, as
    seen with crbug.com/822284.
    
    This change might affect performance in some cases, and we'll need to
    evaluate whether it's worth spending cycles on adding another mechanism
    that leverages the sequential string information in a safe way on a case
    by case basis.
    
    Bug: chromium:822284
    Change-Id: I0de77ec089a774236555f38c365f7548f454edfe
    Reviewed-on: https://chromium-review.googlesource.com/966021Reviewed-by: 's avatarJaroslav Sevcik <jarin@chromium.org>
    Commit-Queue: Jaroslav Sevcik <jarin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#51975}
    36426ab7
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...