• Jakob Gruber's avatar
    [csa] Canonicalize empty elements in AllocateJSArray · 2859dba7
    Jakob Gruber authored
    Prior to this, AllocateJSArray would go ahead and allocate an empty
    FixedArray as elements if passed any capacity that is not a compile-time
    constant 0.
    
    Things break later on since we rely on the fact that empty fixed arrays
    are always canonicalize, and we use
    
      obj.elements == empty_fixed_array_constant
    
    interchangeably with
    
      obj.elements.length == 0.
    
    This CL introduces two new branches in AllocateJSArray: one if the
    capacity is known to be non-zero; and another that explicitly
    distinguishes between 0 and non-zero capacities.
    
    Bug: chromium:760790
    Change-Id: I7c22b19ce9ce15a46f91b0f75e6b4a1ff3a29a0f
    Reviewed-on: https://chromium-review.googlesource.com/645959
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Reviewed-by: 's avatarCamillo Bruni <cbruni@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#47776}
    2859dba7
Name
Last commit
Last update
..
benchmarks Loading commit data...
cctest Loading commit data...
common Loading commit data...
debugger Loading commit data...
fuzzer Loading commit data...
inspector Loading commit data...
intl Loading commit data...
js-perf-test Loading commit data...
memory Loading commit data...
message Loading commit data...
mjsunit Loading commit data...
mkgrokdump Loading commit data...
mozilla Loading commit data...
preparser Loading commit data...
promises-aplus Loading commit data...
test262 Loading commit data...
unittests Loading commit data...
wasm-spec-tests Loading commit data...
webkit Loading commit data...
BUILD.gn Loading commit data...
bot_default.gyp Loading commit data...
bot_default.isolate Loading commit data...
default.gyp Loading commit data...
default.isolate Loading commit data...
optimize_for_size.gyp Loading commit data...
optimize_for_size.isolate Loading commit data...
perf.gyp Loading commit data...
perf.isolate Loading commit data...