• Clemens Backes's avatar
    [wasm] Always clear "thread in wasm flag" in runtime functions · 1e6669a7
    Clemens Backes authored
    From several runtime functions, this was still missing. For some, it
    shouldn't really matter, but some runtime functions (e.g. DebugBreak)
    can call back into JS to wasm, and there it matters.
    
    As it never hurts to clear and re-set the flag, this CL consistently
    resets the flag for all runtime functions called from wasm code. For
    runtime functions that are called from outside of wasm (e.g. from
    wrappers), we add a DCHECK instead that the flag is not set. There is
    one exception (WasmThrowTypeError), which is called both from wasm code
    and from wrappers. In this case it's OK, I added a comment saying why.
    
    Drive-by: Remove obsolete comments (from a time where this clearing
    was still optional in some cases).
    
    R=ahaas@chromium.org
    
    Bug: v8:10389
    Change-Id: Id4ec92a42e89005276b42c145fe3572eb459d220
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2157026Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#67274}
    1e6669a7
Name
Last commit
Last update
..
OWNERS Loading commit data...
runtime-array.cc Loading commit data...
runtime-atomics.cc Loading commit data...
runtime-bigint.cc Loading commit data...
runtime-classes.cc Loading commit data...
runtime-collections.cc Loading commit data...
runtime-compiler.cc Loading commit data...
runtime-date.cc Loading commit data...
runtime-debug.cc Loading commit data...
runtime-forin.cc Loading commit data...
runtime-function.cc Loading commit data...
runtime-futex.cc Loading commit data...
runtime-generator.cc Loading commit data...
runtime-internal.cc Loading commit data...
runtime-interpreter.cc Loading commit data...
runtime-intl.cc Loading commit data...
runtime-literals.cc Loading commit data...
runtime-module.cc Loading commit data...
runtime-numbers.cc Loading commit data...
runtime-object.cc Loading commit data...
runtime-operators.cc Loading commit data...
runtime-promise.cc Loading commit data...
runtime-proxy.cc Loading commit data...
runtime-regexp.cc Loading commit data...
runtime-scopes.cc Loading commit data...
runtime-strings.cc Loading commit data...
runtime-symbol.cc Loading commit data...
runtime-test.cc Loading commit data...
runtime-typedarray.cc Loading commit data...
runtime-utils.h Loading commit data...
runtime-wasm.cc Loading commit data...
runtime-weak-refs.cc Loading commit data...
runtime.cc Loading commit data...
runtime.h Loading commit data...