• Clemens Hammacher's avatar
    [wasm][gc] Make pages inaccessible instead of discarding them · 33dc36d7
    Clemens Hammacher authored
    On Linux, both APIs uses {madvise} (and {SetPermissions} additionally
    does an {mprotect}), on windows they use different APIs. It turns out that
    {SetPermissions} with {kNoAccess} uses {VirtualFree} with
    {MEM_DECOMMIT}, so the pages will only be "reserved" afterwards.
    {DiscardSystemPages} on the other hand uses the {DiscardVirtualMemory}
    which tells the OS that the content of that memory can be discarded,
    but the pages stay "committed".
    Thus {SetPermissions} with {kNoAccess} frees significantly more memory
    than using {DiscardSystemPages}.
    
    R=mstarzinger@chromium.org
    
    Bug: v8:8217
    Change-Id: I3555462a9c692f15ecb3eca7834eb181617d9ef9
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1730992Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
    Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#63029}
    33dc36d7
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...