• alexandre.rames@arm.com's avatar
    A64: Handle a few TODOs. · 33a46be6
    alexandre.rames@arm.com authored
    Notes about a few TODOs handled in this patch:
    
    * In ProfileEntryHookStub::Generate:
        Stubs are always called with relocation.
    
    * In CreateArrayDispatchOneArgument:
        The branches to registers can't be conditional. We could use a jump table, but
        there are only 6 different kinds so it is likely not worth it.
    
    * In Builtins::Generate_StringConstructCode:
        Rename the argc register (x0) after its meaning changes.
        Remove a TODO: using a macro would not make the code clearer.
    
    * In Generate_JSEntryTrampolineHelper:
        Remove the TODO and raise an internal issue to investigate this.
    
    * In Disassembler::SubstituteBranchTargetField:
        Print the target address, but we don't have more info on the target.
    
    R=ulan@chromium.org
    
    Review URL: https://codereview.chromium.org/185793002
    
    git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@19724 ce2b1a6d-e550-0410-aec6-3dcde31c8c00
    33a46be6
Name
Last commit
Last update
benchmarks Loading commit data...
build Loading commit data...
include Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
AUTHORS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
Makefile.nacl Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...