• adamk's avatar
    Fix lazy compilation of eval() under nosnap/--use-strict · 33a37398
    adamk authored
    When running without a snapshot, the GlobalEval function gets lazy compiled.
    By the time we compile it, its name is "eval", which causes the parser to
    choke (functions named "eval" aren't allowed in strict mode!).
    
    Instead, we now always skip checking the function name when lazy-parsing,
    as the name has already been checked appropriately by the preparser.
    
    Also cleaned up other cases that don't require name checking by introducing
    FunctionNameValidity enum and passing appropriate values throughout the
    parser and preparser.
    
    This lets us pass an additional 18 test262 tests.
    
    BUG=v8:4198
    LOG=n
    
    Review URL: https://codereview.chromium.org/1227093005
    
    Cr-Commit-Position: refs/heads/master@{#29559}
    33a37398
Name
Last commit
Last update
benchmarks Loading commit data...
build Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
Makefile.nacl Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...