• Florian Sattler's avatar
    [parser] Remove explicit ok status tracking. · 339bb225
    Florian Sattler authored
    Replace the explicit ok tracing by setting the scanner to fail, allowing us to
    return automatically. RETURN_IF_PARSE_ERROR is now used instead of CHECK_OK to
    verify if the parser failed.
    
    In a follow-up CL we'll merge RETURN_IF_PARSE_ERROR after Expect* into an
    EXPECT* macro. We'll keep (for now) RETURN_IF_PARSE_ERROR that guard uses of
    possible NullExpression (e.g., impl()->IsIdentifier(...)). All other RETURN_IF*
    will be removed. Uses after failure can likely later be fixed too by introducing
    a FailureExpression.
    
    Bug: v8:8363 ,v8:7926
    
    Change-Id: I9896449eb9be476c453da4417a0bfd17c169ff38
    Reviewed-on: https://chromium-review.googlesource.com/c/1294649
    Commit-Queue: Florian Sattler <sattlerf@google.com>
    Reviewed-by: 's avatarMarja Hölttä <marja@chromium.org>
    Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#56972}
    339bb225
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...