• Jakob Kummerow's avatar
    [elements.cc] Specialize CollectValuesOrEntriesImpl · 32b5cad1
    Jakob Kummerow authored
    When collecting the values of an object with Smi or Object elements
    kind, there are no allocations, so we don't need to create a short-
    lived handle for each value. This gives a small performance benefit
    in general, and in particular on ia32 by reducing register pressure
    causes clang to spill less, which fixes the regression in the issue
    mentioned below.
    
    Bug: chromium:833591
    Change-Id: I5eb0c6164b2972306ce965ec101687cab486bf0d
    Reviewed-on: https://chromium-review.googlesource.com/1029417
    Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
    Reviewed-by: 's avatarCamillo Bruni <cbruni@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#52825}
    32b5cad1
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...