• Peter Marshall's avatar
    [cleanup] Replace List with std::vector in api. · 329f6946
    Peter Marshall authored
    The members of HandleScopeImplementer are copied with memcpy when
    the isolate is transferred to another thread. List contained some
    primitives which allowed us to manually free the backing store, which
    was needed in order to ensure that threads would not hold on to
    old pointers and use them later. With std::vector, we can't do that.
    
    Here we change the HandleScopeImplementer to instead use a custom
    structure DetachableVector, which contains a std::vector but allows
    manual detaching and freeing of the backing store. This allows us to
    maintain the old behavior.
    
    Bug: v8:6333
    Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng
    Change-Id: I6361d161cdb19878ba19ed51d6ba2fae99e8cdc0
    Reviewed-on: https://chromium-review.googlesource.com/660125Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Commit-Queue: Peter Marshall <petermarshall@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#48197}
    329f6946
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...