• Simon Zünd's avatar
    [debug] Immediately step-in for 'stack check triggered' debug breaks · 3297ccca
    Simon Zünd authored
    This CL changes debug breaks that are triggered via interrupts (i.e.
    via stack check). One client of this behavior is the `Debugger.pause`
    CDP method.
    
    The problem is that when we pause so early, the JSFunction didn't have
    time yet to create and push it's context. This requires special
    handling in the ScopeIterator and makes an upcoming change unnecessary
    complex.
    
    Another (minor) problem is that local debug-evaluate can't change
    context-allocated local variables (see changed regression bug). Since
    the context is not yet created and pushed, variables are written to
    the DebugEvaluateContext that goes away after the evaluation.
    
    The solution is to mirror what `BreakOnNextFunction` does. Instead
    of staying paused in the middle of the function entry, we trigger
    a "step in" and pause at the first valid breakable position instead.
    This ensures that the function context is already created and pushed.
    
    Note that we do this only in case for JSFunctions. In all other cases
    we keep the existing behavior and stay paused in the entry.
    
    R=jgruber@chromium.org
    
    Fixed: chromium:1246907
    Change-Id: I0cd8ae6e049a3b55bdd44858e769682a1ca47064
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3854501Reviewed-by: 's avatarJakob Linke <jgruber@chromium.org>
    Commit-Queue: Simon Zünd <szuend@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#82817}
    3297ccca
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
maglev Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sandbox Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
temporal Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...