• bmeurer's avatar
    [crankshaft] Make the for-in slow path compatible with the other compilers. · 3251a03e
    bmeurer authored
    So far the for-in slow path in Crankshaft unconditionally called
    %ForInFilter for every iteration of the for-in loop, without paying
    attention to the possible enum cache equipped receiver map. So even
    though we iterate the enum cache FixedArray associated with the map
    we don't check the map, but always go to %ForInFilter. This would be
    perfectly fine if the enum cache FixedArray would be immutable, but
    due to some funny GC/runtime interaction kicking in, the enum cache
    can be right trimmed while we are iterating it, and the only way to
    detect this is to ensure that we check the map when accessing the
    enum cache.
    
    BUG=v8:3650,v8:4715
    LOG=n
    
    Review URL: https://codereview.chromium.org/1650493002
    
    Cr-Commit-Position: refs/heads/master@{#33599}
    3251a03e
Name
Last commit
Last update
benchmarks Loading commit data...
build Loading commit data...
docs Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
Makefile.nacl Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...