• Adam Klein's avatar
    [ast] Move AstValue implementation into Literal · 317cf321
    Adam Klein authored
    This eliminates the AstValue class, effectively moving its
    implementation into the Literal AstNode. This should cause
    no difference in behavior, but it does signal some shifts
    in the underlying system. Biggest changes include:
    
      - Reduction in AST memory usage
      - No duplicate HeapNumbers in Ignition constant pools
      - Non-String values are allocated either at constant pool
        creation time (or at boilerplate creation time for literals),
        rather than at AstValueFactory::Internalize() time.
    
    There are a variety of test-only/debug-only changes due to these
    switches as well.
    
    Bug: v8:6984
    Change-Id: I5f178040ce2796d4e7370c24d1063419e1c843a1
    Reviewed-on: https://chromium-review.googlesource.com/731111
    Commit-Queue: Adam Klein <adamk@chromium.org>
    Reviewed-by: 's avatarRoss McIlroy <rmcilroy@chromium.org>
    Reviewed-by: 's avatarMarja Hölttä <marja@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#49013}
    317cf321
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...