• Clemens Backes's avatar
    [wasm][profiler] Fix late enabling of the profiler · 31005b5c
    Clemens Backes authored
    We had a test which first enabled the profiler, and then compiled wasm
    code. In this case, all code objects were registered correctly and the
    profile looked as expected.
    This CL extends the test for also test another order: First compile the
    wasm code, then enable the profiler. In that case, we were reporting a
    wrong debug name of the exported wasm function. The name of that
    function is spec'ed to be the string representation of the function
    index. But for debugging, we want to see a more meaningful name,
    identical to the name we show when reporting the code during
    compilation.
    
    This fix requires handlifying the {SharedFunctionInfo::DebugName}
    method, because for exported wasm functions, it needs to allocate a new
    name on the JS heap.
    In order to avoid this allocation where possible, a second variant is
    added which returns a unique_ptr directly. This can be used in all
    places where the name is just being printed, which turned out to be the
    majority of cases ({DebugName().ToCString()}).
    
    R=petermarshall@chromium.org
    
    Bug: chromium:1141787
    Change-Id: I0343c2f06f0b852007535ff07459b712801ead01
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2543931
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
    Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
    Reviewed-by: 's avatarPeter Marshall <petermarshall@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#71308}
    31005b5c
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...