• littledan's avatar
    [intl] Fall back on an invalid default locale to "und" · 3059138b
    littledan authored
    The default locale can be changed in some environments with environment
    variables. These environment variables used to allow the system to get
    into an invalid state, where the default locale was unsupported. This
    patch detects that case and falls back to "und" as the default locale
    if there is an Intl service which does not support the locale that ICU
    reports as the default. It also has a slight cleanup of surrounding code.
    
    I haven't gone through the work to set up an automated test, as triggering
    the case requires setting environment variables, which our tests don't tend
    to do, but I tested interactively as follows:
    
    dehrenberg@dehrenberg:~/v8/v8$ LC_ALL="tlh-FR" rlwrap out/Release/d8
    V8 version 5.7.0 (candidate)
    d8> new Intl.NumberFormat("foo").resolvedOptions().locale
    "und"
    d8> new Intl.NumberFormat().resolvedOptions().locale
    "und"
    d8>
    
    dehrenberg@dehrenberg:~/v8/v8$ LC_ALL="de" rlwrap out/Release/d8
    V8 version 5.7.0 (candidate)
    d8> new Intl.NumberFormat().resolvedOptions().locale
    "de"
    d8> new Intl.NumberFormat("foo").resolvedOptions().locale
    "de"
    d8>
    
    BUG=v8:4216
    
    Review-Url: https://codereview.chromium.org/2646593002
    Cr-Commit-Position: refs/heads/master@{#43253}
    3059138b
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...