• Leszek Swirski's avatar
    [parser] Fix caching dynamic vars on wrong scope · 304e97d3
    Leszek Swirski authored
    When looking up a variable in a deserialized WITH scope, we were
    unconditionally passing in the cache scope to the lookup, even if the
    with was inside the cache scope. This would lead to and outer scope of
    the with holding the generated dynamic variable. If the cache scope was
    the SCRIPT scope, the dynamic variable would be interpreted as a global
    object property.
    
    Now, we only store the WITH scope dynamic variables in the cache scope
    if it is an inner scope of the WITH scope, same as we do for 'normal'
    scope lookups.
    
    Fixed: chromium:1041210
    Change-Id: I4e8eb25bbb8ea58311355d13a9c7c97bf2fa3ec7
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1997135Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
    Commit-Queue: Toon Verwaest <verwaest@chromium.org>
    Auto-Submit: Leszek Swirski <leszeks@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#65732}
    304e97d3
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...