• Michael Achenbach's avatar
    Revert "[turbofan] Inline StringCharCodeAt like Crankshaft did." · 2fe91a91
    Michael Achenbach authored
    This reverts commit 93d67d20.
    
    Reason for revert: several layout test failures:
    https://build.chromium.org/p/client.v8.fyi/builders/V8-Blink%20Linux%2064/builds/21062
    
    Original change's description:
    > [turbofan] Inline StringCharCodeAt like Crankshaft did.
    > 
    > This avoids the call to the StringCharCodeAt builtin from
    > within TurboFan optimized code and instead emits a loop
    > that does the character load. This (together with previously
    > reverted CL to the JSCallReducer) almost completely recovers
    > the performance regression caused when we shipped TurboFan.
    > 
    > Without untrusted code mitigations the benchmark goes from
    > 580ms to roughly 490ms, and with the patch to the JSCallReducer
    > the time goes down to 280ms, which is very close to what we
    > had with Crankshaft.
    > 
    > This also renames the LoadFromString helper method in the
    > EffectControlLinearizer to LoadFromSeqString to make it
    > clear what it does.
    > 
    > Bug: v8:7326
    > Change-Id: Ibe0ec1847911a234f244bd8dcec6be18b241fda0
    > Reviewed-on: https://chromium-review.googlesource.com/873376
    > Reviewed-by: Yang Guo <yangguo@chromium.org>
    > Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#50702}
    
    TBR=yangguo@chromium.org,bmeurer@chromium.org
    
    Change-Id: I6e909adba82adc46e269ab14426ee24caaca6ff9
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:7326
    Reviewed-on: https://chromium-review.googlesource.com/875963Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
    Commit-Queue: Michael Achenbach <machenbach@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#50709}
    2fe91a91
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...