• Leszek Swirski's avatar
    [maglev] Fix ResumeGenerator reviving a dead SuspendGenerator · 2f41221f
    Leszek Swirski authored
    ResumeGenerator is semantically a successor of SuspendGenerator (for
    reasoning about liveness), but operationally it's a successor of
    SwitchOnGeneratorState. This means that the jump to ResumeGenerator will
    always create a new basic block, even if the SuspendGenerator was dead.
    
    This causes problems if we made other assumptions on liveness based on
    the semantics; in particular, we assume that JumpLoop is dead if the
    loop header is dead (thanks to loop irreducibility).
    SwitchOnGeneratorState breaks irreducibility, and this manifests as the
    JumpLoop being alive and trying to jump to a dead header.
    
    Since this is a special case, and loops are otherwise irreducible, we
    can also fix it with a special case; namely, MarkBytecodeDead now has a
    special case for SuspendGenerator which manually advances the iterator
    and kills the ResumeGenerator.
    
    Bug: v8:7700
    Change-Id: Ice162f061e7ba1dda7ceb4f6fe9234889655b417
    Fixed: v8:13250
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3865556Reviewed-by: 's avatarVictor Gomes <victorgomes@chromium.org>
    Commit-Queue: Victor Gomes <victorgomes@chromium.org>
    Auto-Submit: Leszek Swirski <leszeks@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#82931}
    2f41221f
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
maglev Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sandbox Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
temporal Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...