• Leszek Swirski's avatar
    [maglev] Fix ResumeGenerator reviving a dead SuspendGenerator · 2f41221f
    Leszek Swirski authored
    ResumeGenerator is semantically a successor of SuspendGenerator (for
    reasoning about liveness), but operationally it's a successor of
    SwitchOnGeneratorState. This means that the jump to ResumeGenerator will
    always create a new basic block, even if the SuspendGenerator was dead.
    
    This causes problems if we made other assumptions on liveness based on
    the semantics; in particular, we assume that JumpLoop is dead if the
    loop header is dead (thanks to loop irreducibility).
    SwitchOnGeneratorState breaks irreducibility, and this manifests as the
    JumpLoop being alive and trying to jump to a dead header.
    
    Since this is a special case, and loops are otherwise irreducible, we
    can also fix it with a special case; namely, MarkBytecodeDead now has a
    special case for SuspendGenerator which manually advances the iterator
    and kills the ResumeGenerator.
    
    Bug: v8:7700
    Change-Id: Ice162f061e7ba1dda7ceb4f6fe9234889655b417
    Fixed: v8:13250
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3865556Reviewed-by: 's avatarVictor Gomes <victorgomes@chromium.org>
    Commit-Queue: Victor Gomes <victorgomes@chromium.org>
    Auto-Submit: Leszek Swirski <leszeks@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#82931}
    2f41221f
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.style.yapf Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...