• Ross McIlroy's avatar
    [Heap] Don't try and find SFIs FunctionLiteralId when flushing it's bytecode. · 2e83e749
    Ross McIlroy authored
    For compiled SFIs, finding the FunctionLiteralId is a slow operation that requires
    doing a binary search in the script's SFI table. Given the SFI has been flushed,
    it is unlikely we will need the FunctionLiteralId again, so just mark the
    UncompiledData has having an invalid FunctionLiteralID such that we only do
    the search if it is required from the UncompiledData.
    
    This addresses a significant regression on gc_latency when bytecode flushing was
    enabled.
    
    BUG=chromium:927038,v8:8395
    
    Change-Id: I7123c3fe05034ff96e84f9d1d36d5f312a2a56e0
    Reviewed-on: https://chromium-review.googlesource.com/c/1450118Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
    Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#59319}
    2e83e749
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...