• Jakob Gruber's avatar
    [regexp] Fix CharacterRange limits again again again · 2e17aaca
    Jakob Gruber authored
    When emitting code, character ranges must only specify ranges which
    the actual subject string (one- or two-byte) may contain.
    
    This was not always the case, specifically for ranges with
    `from <= kMaxUint8` and `to > kMaxUint8`.
    
    The reason this is so tricky: 1. not all parts of the pipeline know
    whether we are compiling for one- or two-byte subjects; 2. for
    case-insensitive regexps, an out-of-bounds CharacterRange may have an
    in-bounds case equivalent (e.g. /[Ÿ]/i also matches 'ÿ' == \u{ff}),
    which only gets added somewhere in the middle of the pipeline.
    
    Our current solution is to clamp immediately before code emission. We
    also keep the existing handling/dchecks of the 0x10ffff marker value
    which may occur in the two-byte subject case.
    
    Bug: v8:11069
    Change-Id: Ic7b34a13a900ea2aa3df032daac9236bf5682a42
    Fixed: chromium:1275096
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3306569
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#78186}
    2e17aaca
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
security Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
temporal Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...