• Simon Zünd's avatar
    Change debug-evaluate from a whitelist to a blacklist approach · 2e11dff7
    Simon Zünd authored
    This CL changes how variables are resolved during debug evaluate.
    We now re-parse the whole script when creating a ScopeIterator.
    This gives us accurate scope information for all parent scopes of the
    closure in which we stopped. Using this information, we build
    blacklists of stack-allocated variables. Each context on the chain
    in between the closure context up to the original native context is
    wrapped in a debug-evaluate context with such a blacklist attached.
    Variable lookup for debug-evalute contexts then works as follows:
    
      1) Look up in the materialized stack variables (stayed the same).
      2) Check the blacklist to find out whether to abort further lookup.
      3) Look up in the original context.
    
    Steps 1-3 is repeated for each debug-evaluate context, since they
    mirror the original context chain.
    
    R=ulan@chromium.org, yangguo@chromium.org
    
    Change-Id: Ied8e5786772c70566da9627ee3b7eff066fba2b4
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1795354Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
    Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Commit-Queue: Simon Zünd <szuend@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#63666}
    2e11dff7
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...