• Leszek Swirski's avatar
    [maglev] Always use spill slots in lazy deopts · 2d3f21cf
    Leszek Swirski authored
    Lazy deopts are always after calls, so force them to spill their inputs.
    This would normally be the case anyway, except for deferred calls, which
    don't tell the register allocator to spill like normal calls do.
    
    This makes lazy deopt regalloc always spill its inputs and use their
    spill slot, but unlike calls, this doesn't additionally clear the
    register, so subsequent nodes can continue using the register cached
    value without having to reload it.
    
    As drive-bys, fix the Throw* opcodes to have the Throw property, and use
    detail::DeepForEachInput in a couple of extra locations (including for
    lazy deopts).
    
    Bug: v8:7700
    Change-Id: I89b04f17ca781d4f69ff0ed07566fa583aa677e6
    Fixed: chromium:1364074
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3899009Reviewed-by: 's avatarJakob Linke <jgruber@chromium.org>
    Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    Commit-Queue: Jakob Linke <jgruber@chromium.org>
    Auto-Submit: Leszek Swirski <leszeks@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#83293}
    2d3f21cf
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.style.yapf Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...