• adamk's avatar
    ParameterInitializerRewriter must maintain temporary variable order · 2d090ee4
    adamk authored
    When the rewriter moves a temporary variable between scopes, it must
    be sure to maintain the order, so that the rewritten order is the
    same as it would have been without rewriting.
    
    To expose the difference in behavior, this patch removes the superfluous
    visitation of ForOfStatement::each() from AstExpressionVisitor, which
    happened to be the only thing keeping all the temporaries in order
    in mjsunit/harmony/regress/regress-crbug-578038.js. Without the proper
    order, this test would fail under --stress-opt, because the ".for"
    variable (behind the "each" proxy) would get two different positions
    in the scope, one on first parse (with rewriting) and the other on
    second parse (lazy parsing for optimization).
    
    A follow-up patch will remove each() and iterable() from ForOfStatement
    altogether, but I wanted to keep this patch small to highlight exactly
    the bit of code needed to make the test pass when not visiting each().
    
    BUG=v8:4791
    LOG=n
    
    Review-Url: https://codereview.chromium.org/1784893003
    Cr-Commit-Position: refs/heads/master@{#36150}
    2d090ee4
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
Makefile.nacl Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...