• mvstanton's avatar
    [Builtins] New Array.prototype.filter implementation observability bug. · 2c84924f
    mvstanton authored
    filter creates an output array with the Array species constructor for
    storing values from the input array that pass the user-supplied
    predicate function. Our new array builtins are implemented such that
    if we fall out of the fast path, we'll pick up where we left off
    in a continuation function. It's important to pass the index of
    where we left off appending to the output array, because otherwise
    we will read it at the start of the continuation function.
    
    That would be observable, and a spec violation.
    
    BUG=
    
    Review-Url: https://codereview.chromium.org/2771483002
    Cr-Commit-Position: refs/heads/master@{#44023}
    2c84924f
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...