• Andreas Haas's avatar
    [wasm] Allow to restart background tasks during streaming compilation · 2c3fae96
    Andreas Haas authored
    In a certain scenario streaming compilation got stuck and did never
    finish. This CL fixes this issue.
    
    Scenario:
    * Streaming compilation starts
    * The compilation tasks execute all compiation units in the working
      queue and set the finished_ flag to true.
    * New data arrives over streaming
    * The compilation tasks compile so fast that the executed_units_ queue
      gets full. The compilation tasks stop executing and wait for the
      finisher task to restart them.
    * The finisher task does not restart the compilation tasks because the
      finished_ flag is set.
    
    With this CL I remove the finished flag and instead look at the size
    of the working queue directly.
    
    In addition I added a test which does not actually reproduce this
    scenario but seems good to have anyways.
    
    R=mtrofin@chromium.org
    
    Change-Id: I44560c43e51be13c4461208368e21137b115656c
    Reviewed-on: https://chromium-review.googlesource.com/824523Reviewed-by: 's avatarMircea Trofin <mtrofin@chromium.org>
    Commit-Queue: Andreas Haas <ahaas@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#50090}
    2c3fae96
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...