• Clemens Backes's avatar
    [wasm] Refactor and fix wasm serialization test · 9349fb78
    Clemens Backes authored
    This fixes a few issues:
    1) It avoids using the {DeserializeOrCompile} API method, which is not
       used in chrome any more and will be deprecated soon.
    2) It switches to the {DeserializeNativeModule} internal method, which
       really checks deserialization in isolation and does not fall back to
       compiling the wire bytes if the serialized bytes are incorrect.
    3) It disables a test which tried to invalidate the number of functions,
       but the respective bytes were already zero, so nothing was
       invalidated. This still needs to be fixed in a follow-up CL.
    4) It serializes the modules in a separate isolate, which then gets
       disposed to free references to the NativeModule and remove it from
       the modules cache. Otherwise we will just never deserialize, but use
       the cached module instead.
    
    R=thibaudm@chromium.org
    
    Bug: v8:6847, v8:10146
    Change-Id: I37ef524a9c96c32fec2e7466488d67395fa5ccea
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2010786
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Reviewed-by: 's avatarThibaud Michaud <thibaudm@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#65888}
    9349fb78
Name
Last commit
Last update
..
OWNERS Loading commit data...
test-c-wasm-entry.cc Loading commit data...
test-compilation-cache.cc Loading commit data...
test-grow-memory.cc Loading commit data...
test-jump-table-assembler.cc Loading commit data...
test-liftoff-inspection.cc Loading commit data...
test-run-wasm-64.cc Loading commit data...
test-run-wasm-asmjs.cc Loading commit data...
test-run-wasm-atomics.cc Loading commit data...
test-run-wasm-atomics64.cc Loading commit data...
test-run-wasm-bulk-memory.cc Loading commit data...
test-run-wasm-exceptions.cc Loading commit data...
test-run-wasm-interpreter.cc Loading commit data...
test-run-wasm-js.cc Loading commit data...
test-run-wasm-module.cc Loading commit data...
test-run-wasm-sign-extension.cc Loading commit data...
test-run-wasm-simd-liftoff.cc Loading commit data...
test-run-wasm-simd.cc Loading commit data...
test-run-wasm.cc Loading commit data...
test-streaming-compilation.cc Loading commit data...
test-wasm-breakpoints.cc Loading commit data...
test-wasm-codegen.cc Loading commit data...
test-wasm-import-wrapper-cache.cc Loading commit data...
test-wasm-interpreter-entry.cc Loading commit data...
test-wasm-serialization.cc Loading commit data...
test-wasm-shared-engine.cc Loading commit data...
test-wasm-stack.cc Loading commit data...
test-wasm-trap-position.cc Loading commit data...
wasm-atomics-utils.h Loading commit data...
wasm-run-utils.cc Loading commit data...
wasm-run-utils.h Loading commit data...