• ahaas's avatar
    Revert of [turbofan] Correct regalloc blocked register behavior (patchset #2... · 2b97f79a
    ahaas authored
    Revert of [turbofan] Correct regalloc blocked register behavior (patchset #2 id:60001 of https://codereview.chromium.org/2652153005/ )
    
    Reason for revert:
    Introduces new crashers, e.g.
    
    load("test/mjsunit/wasm/wasm-constants.js");
    load("test/mjsunit/wasm/wasm-module-builder.js");
    
    (function() {
      var builder = new WasmModuleBuilder();
      builder.addMemory(16, 32, false);
      builder.addFunction("test", kSig_i_iii)
        .addBodyWithEnd([
    // body:
    kExprI64Const, 0x42,
    kExprI64Const, 0x7a,
    kExprI64Ctz,
    kExprI64Mul,
    kExprI64Ctz,
    kExprI64Const, 0x41,
    kExprI64Ctz,
    kExprI64Ctz,
    kExprI64Shl,
    kExprI64Const, 0x41,
    kExprI64Ctz,
    kExprI64Ctz,
    kExprI64Shl,
    kExprF32SConvertI64,
    kExprUnreachable,
    kExprEnd,   // @20
                ])
                .exportFunc();
      var module = builder.instantiate();
      module.exports.test(1, 2, 3);
    })();
    
    Original issue's description:
    > [turbofan] Correct regalloc blocked register behavior
    >
    >
    > This corrects the case when we need to allocate a
    > blocked register, but the blockage happens after a
    > use as an instruction input, and there's no place to
    > split before that.
    >
    > BUG=v8:5888
    >
    > Review-Url: https://codereview.chromium.org/2652153005
    > Cr-Commit-Position: refs/heads/master@{#42706}
    > Committed: https://chromium.googlesource.com/v8/v8/+/ca779b29a60785d962d7cd636f6b0f09e66130b3
    
    TBR=bmeurer@chromium.org,jarin@chromium.org,mtrofin@chromium.org
    # Skipping CQ checks because original CL landed less than 1 days ago.
    NOPRESUBMIT=true
    NOTREECHECKS=true
    NOTRY=true
    BUG=v8:5888
    
    Review-Url: https://codereview.chromium.org/2654993007
    Cr-Commit-Position: refs/heads/master@{#42707}
    2b97f79a
Name
Last commit
Last update
..
benchmarks Loading commit data...
cctest Loading commit data...
common Loading commit data...
debugger Loading commit data...
fuzzer Loading commit data...
inspector Loading commit data...
intl Loading commit data...
js-perf-test Loading commit data...
memory Loading commit data...
message Loading commit data...
mjsunit Loading commit data...
mozilla Loading commit data...
preparser Loading commit data...
promises-aplus Loading commit data...
simdjs Loading commit data...
test262 Loading commit data...
unittests Loading commit data...
webkit Loading commit data...
BUILD.gn Loading commit data...
bot_default.gyp Loading commit data...
bot_default.isolate Loading commit data...
default.gyp Loading commit data...
default.isolate Loading commit data...
optimize_for_size.gyp Loading commit data...
optimize_for_size.isolate Loading commit data...
perf.gyp Loading commit data...
perf.isolate Loading commit data...