• ahaas's avatar
    Revert of [turbofan] Correct regalloc blocked register behavior (patchset #2... · 2b97f79a
    ahaas authored
    Revert of [turbofan] Correct regalloc blocked register behavior (patchset #2 id:60001 of https://codereview.chromium.org/2652153005/ )
    
    Reason for revert:
    Introduces new crashers, e.g.
    
    load("test/mjsunit/wasm/wasm-constants.js");
    load("test/mjsunit/wasm/wasm-module-builder.js");
    
    (function() {
      var builder = new WasmModuleBuilder();
      builder.addMemory(16, 32, false);
      builder.addFunction("test", kSig_i_iii)
        .addBodyWithEnd([
    // body:
    kExprI64Const, 0x42,
    kExprI64Const, 0x7a,
    kExprI64Ctz,
    kExprI64Mul,
    kExprI64Ctz,
    kExprI64Const, 0x41,
    kExprI64Ctz,
    kExprI64Ctz,
    kExprI64Shl,
    kExprI64Const, 0x41,
    kExprI64Ctz,
    kExprI64Ctz,
    kExprI64Shl,
    kExprF32SConvertI64,
    kExprUnreachable,
    kExprEnd,   // @20
                ])
                .exportFunc();
      var module = builder.instantiate();
      module.exports.test(1, 2, 3);
    })();
    
    Original issue's description:
    > [turbofan] Correct regalloc blocked register behavior
    >
    >
    > This corrects the case when we need to allocate a
    > blocked register, but the blockage happens after a
    > use as an instruction input, and there's no place to
    > split before that.
    >
    > BUG=v8:5888
    >
    > Review-Url: https://codereview.chromium.org/2652153005
    > Cr-Commit-Position: refs/heads/master@{#42706}
    > Committed: https://chromium.googlesource.com/v8/v8/+/ca779b29a60785d962d7cd636f6b0f09e66130b3
    
    TBR=bmeurer@chromium.org,jarin@chromium.org,mtrofin@chromium.org
    # Skipping CQ checks because original CL landed less than 1 days ago.
    NOPRESUBMIT=true
    NOTREECHECKS=true
    NOTRY=true
    BUG=v8:5888
    
    Review-Url: https://codereview.chromium.org/2654993007
    Cr-Commit-Position: refs/heads/master@{#42707}
    2b97f79a
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...