• Michael Starzinger's avatar
    [wasm] Fix lifetime of reference values on interpreter stack. · 2b7fdbfc
    Michael Starzinger authored
    This ensures the lifetime of reference values on the simulated operand
    stack of the interpreter is coupled to a lifetime of the {ThreadImpl}.
    We no longer directly store reference values on the stack, but maintain
    a separate "reference stack" on the GC'ed heap. This will ensure the GC
    traces such references properly.
    
    The new {StackValue} safety wrapper makes sure all use-sites that access
    the operand stack properly convert to/from handles when dealing with
    reference values.
    
    R=clemensh@chromium.org
    TEST=mjsunit/wasm/exceptions-interpreter
    BUG=v8:8091,v8:7581
    
    Change-Id: I8c05f2d945a6def943b89be0cfca538a73df8855
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1552791
    Commit-Queue: Michael Starzinger <mstarzinger@chromium.org>
    Reviewed-by: 's avatarClemens Hammacher <clemensh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#60650}
    2b7fdbfc
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...