• Marja Hölttä's avatar
    [parser] Skipping inner funcs: fix the test setup. · 2b730f63
    Marja Hölttä authored
    The test setup was as follows:
    - Preparse function test() { ... }, get scope allocation data.
    - Apply the scope allocation data to (function test() { ... })();
    - Compare against normal scope allocation for (function test() { ... })();
    
    But the IIFE is unnecessary - we already disable lazy parsing.
    
    Cleaning this up is needed because in the next CL, I want to fix the Scopes
    produced by PreParser in this case:
    
    let f = function g() {
      // Here we should declare g!
    }
    
    And that fix will make the variables in
    function test() {
      // Here we don't declare test
    }
    and
    (function test() {
      // Here we do declare test
    })();
    not match any more, so it doesn't make sense to compare them against each other.
    
    BUG=v8:5516
    
    Change-Id: I93d154c6977bb3cbe405b6ca193cf6283df297bc
    Reviewed-on: https://chromium-review.googlesource.com/543341Reviewed-by: 's avatarDaniel Vogelheim <vogelheim@chromium.org>
    Commit-Queue: Marja Hölttä <marja@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#46128}
    2b730f63
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...