• Ben L. Titzer's avatar
    [wasm] Improve fastpath for getting simple opcode signature · 2b5f7205
    Ben L. Titzer authored
    This CL improves the parsing and validation speed of WASM bytecode by
    eliminating a call to get the "simple opcode signature" on the fast
    path. It introduces a byte-indexed array that points directly to a
    FunctionSig*. By declaring the array in the  wasm-opcodes.h header file
    and initializing (constexpr) in the wasm-opcodes.cc file, the decoder
    can use this array directly in its first test. (Note that constexpr
    obviates the need for LazyInitialize in previous iterations of this
    mechanism).
    
    There are two more calls on this fast path that can be simplified,
    WasmOpcodes::IsSignExtensionOpcode() and WasmOpcodes::IsAnyRefOpcode().
    These calls are needed to check for a feature flag and can be
    implemented differently in a followup CL.
    
    R=mstarzinger@chromium.org
    
    Change-Id: Ibb4adb1134932c7e0b6a35facec4d8dd8c998c56
    Reviewed-on: https://chromium-review.googlesource.com/1075276Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
    Commit-Queue: Ben Titzer <titzer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#53391}
    2b5f7205
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...