• joransiu's avatar
    S390:Update inline asm constraint in test-platform · 2b4c9c10
    joransiu authored
    The GetStackPointer() routine in test-platform uses an inline
    assembly code to store the current stack pointer value into a static
    variable sp_addr.  The existing asm code for S390 uses an ST/STG
    instruction, with the memory operand associated with the general ('=g')
    constraint to sp_addr.
    
    On GCC 4.8.5, the GCC compiler got confused and treated sp_addr as
    an integer operand instead of memory operand, resulting in a store
    being emitted that writes to an invalid meory location.
    
    Given the specific store instructions being inlined here, we should
    restict the sp_addr operand to explicitly be a memory operand using '=m'
    instead of '=g'.
    
    R=bmeurer@chromium.org,jkummerow@chormium.org,rmcilroy@chromium.org,yangguo@chromium.org
    BUG=
    
    Review-Url: https://codereview.chromium.org/2158523002
    Cr-Commit-Position: refs/heads/master@{#37809}
    2b4c9c10
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
Makefile.nacl Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...