• Simon Zünd's avatar
    [array] Move Array#sort pre-processing to Torque · 2b0ac2fb
    Simon Zünd authored
    This CL removes the "PrepareElementsForSort" runtime function, and
    replaces it with a simpler version in Torque. The biggest difference
    is that certain sparse configurations no longer have a fast-path.
    
    The Torque pre-processing step replaces the existing Torque mechanism that
    copied already pre-processed elements into the "work" FixedArray. The Torque
    compacting works as follows:
      - Iterate all elements from 0 to {length}
        - If the element is the hole: Do nothing.
        - If the element is "undefined": Increment undefined counter.
        - In all other cases, push the element into the "work" FixedArray.
    
    Then the "work" FixedArray is sorted as before. Writing the elements from
    the "work" array back into the receiver, after sorting, has three steps:
      1. Copy the sorted elements from the "work" FixedArray to the receiver.
      2. Add previously counted number of "undefined" to the receiver.
      3. Depending on the backing store either delete properties or
         set them to the Hole up to {length}.
    
    Bug: v8:8714
    Change-Id: I14eccb7cfd2e4618bce2a85cba0689d7e0380ad2
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1619756
    Commit-Queue: Simon Zünd <szuend@chromium.org>
    Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#61812}
    2b0ac2fb
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...