• Jungshik Shin's avatar
    Use ICU to validate and canonicalize lang tag · 2abb31a9
    Jungshik Shin authored
    - Get rid of an unnecessary call to uloc_canonicalize in js-locale.
    - Do not use regex, but rely on ICU for the structrural validity check
    with Chrome's ICU or ICU 63 or newer. Otherwise, continue to use regex.
    
    This became possible thanks to a couple of bug fixes in ICU ToT that
    were cherry-picked for Chromium's ICU.
    
    Not yet done is to change js-locale to use CanonicalizeLocale().
    That will make a few more tests pass.
    
    Bug: v8:8135
    Test: test262/intl402/Intl/getCanonicalLocales/*
    Test: test262/intl402/Locale/*
    Cq-Include-Trybots: luci.v8.try:v8_linux_noi18n_rel_ng
    Cq-Include-Trybots: luci.chromium.try:linux_chromium_rel_ng
    Change-Id: I45c10b298fb041e0b39a4d96309c68a7966f91c2
    Reviewed-on: https://chromium-review.googlesource.com/c/1215223
    Commit-Queue: Jungshik Shin <jshin@chromium.org>
    Reviewed-by: 's avatarSathya Gunasekaran <gsathya@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#56399}
    2abb31a9
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...