• vabr's avatar
    Remove SMI length check from Builtins::Generate_ArrayIndexOf · 2a7957b9
    vabr authored
    Currently, Generate_ArrayIndexOf handles the hypothetical case of an array with
    a fast ElementsKind and non-SMI length. This should not happen (and is checked
    against in JSArray::JSArrayVerify of objects_debug.cc).
    
    Therefore this CL replaces that handling with a CSA_ASSERT that the length is
    indeed SMI.
    
    The CL also simplifies loading of the (SMI) length on 64 bit architectures by
    using LoadAndUntagObjectField instead of LoadObjectField+SmiToWord.
    
    The CL does not add new tests, because test/mjsunit/array-length.js should
    cover this already.
    
    BUG=v8:5985
    
    Review-Url: https://codereview.chromium.org/2714173002
    Cr-Commit-Position: refs/heads/master@{#43431}
    2a7957b9
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...