• Clemens Backes's avatar
    [wasm] Improve code size estimate for streaming · 77a2b4c1
    Clemens Backes authored
    In streaming compilation, we were computing a way too low code size
    estimate, since all {WasmFunction::code} fields were still zero when we
    were calling {EstimateNativeModuleCodeSize}. This lead to many separate
    code spaces being created during compilation, creating significant
    performance and memory overhead.
    
    This CL fixes this by passing the code section length when creating the
    {NativeModule}. From this, we can compute the code size estimate just as
    before.
    
    Drive-by: Rename "functions_count" to "num_functions" in
    {ProcessCodeSectionHeader} to be consistent with the declaration.
    
    R=ahaas@chromium.org
    
    Bug: v8:9950
    Change-Id: I30a54c01ed24d0dfecb8a4b6d123015f1803ddeb
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1903439
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#64849}
    77a2b4c1
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
assembler Loading commit data...
base Loading commit data...
codegen Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
date Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
heap Loading commit data...
interpreter Loading commit data...
libplatform Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parser Loading commit data...
profiler Loading commit data...
regress Loading commit data...
strings Loading commit data...
tasks Loading commit data...
torque Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
BUILD.gn Loading commit data...
DEPS Loading commit data...
run-all-unittests.cc Loading commit data...
test-helpers.cc Loading commit data...
test-helpers.h Loading commit data...
test-utils.cc Loading commit data...
test-utils.h Loading commit data...
testcfg.py Loading commit data...
unittests.status Loading commit data...