• bmeurer's avatar
    [turbofan] JSCreateClosure doesn't have any JS observable side effects. · 2a20ded9
    bmeurer authored
    The JSCreateClosure operator was not marked as Eliminatable, esp. it
    wasn't marked as NoWrite (read: no JavaScript observable side-effect),
    which lead to a weird performance cliff with the new Array builtin
    inlining. For example
    
      a.forEach(c => c);
    
    was not inlined, whereas
    
      const f = c => c;
      a.forEach(f);
    
    was properly inlined, despite not causing any trouble for TurboFan in
    general. The reason was that the JSCreateClosure for the arrow function
    was marked as "can cause potential side effect", which it cannot. This
    fixes the operator to be properly marked as Eliminatable, thus removing
    this performance cliff.
    
    BUG=v8:1956,v8:6475
    R=danno@chromium.org
    
    Review-Url: https://codereview.chromium.org/2930933002
    Cr-Commit-Position: refs/heads/master@{#45801}
    2a20ded9
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...