• Benedikt Meurer's avatar
    [builtins] Fix no elements check on the prototype chain. · 293283d5
    Benedikt Meurer authored
    Invoking Object.freeze on either the Object.prototype or the
    Array.prototype changes its elements backing store to
    DICTIONARY_ELEMENTS kind, which is not properly checked in all
    placeswhere we test for elements in the prototype chain, i.e. in
    JSObject::PrototypeHasNoElements. This causes several Array
    builtins to take the slow path, i.e. Array.prototype.splice.
    
    Fix this for now by consistently checking for either empty_fixed_array
    or empty_slow_element_dictionary in both C++ and CSA runtime.
    
    Bug: v8:6689
    Change-Id: I3f62643131b3a874b5c2a3d7ed054dd1e799bbaf
    Reviewed-on: https://chromium-review.googlesource.com/608127Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#47264}
    293283d5
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...