• Clemens Backes's avatar
    [wasm] Disable permission switching if MAP_JIT is available · 2890419f
    Clemens Backes authored
    The combination of --wasm-write-protect-code-memory and MAP_JIT was not
    handled correctly. We were trying to unnecessarily switch permissions,
    and a DCHECK was failing because the writers count was not increased
    previously (because the {CodeSpaceWriteScope} uses a separate
    implementation if MAP_JIT is available).
    
    This CL fixes the issues by explicitly setting
    {WasmCodeAllocator::protect_code_memory_} to false if MAP_JIT is being
    used.
    
    R=jkummerow@chromium.org
    
    Bug: v8:12070
    Change-Id: Ifb05ba01f8e2e7781d7c29fe80d1144a3d65543b
    Cq-Include-Trybots: luci.v8.try:v8_mac_arm64_rel_ng
    Cq-Include-Trybots: luci.v8.try:v8_mac_arm64_dbg_ng
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3089159Reviewed-by: 's avatarJakob Kummerow <jkummerow@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#76233}
    2890419f
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...