• Michael Achenbach's avatar
    Revert "[wasm] Fix tier-up budget tracking for recursive calls" · 2864fd0f
    Michael Achenbach authored
    This reverts commit 15f372af.
    
    Reason for revert: https://crbug.com/v8/12984
    
    Original change's description:
    > [wasm] Fix tier-up budget tracking for recursive calls
    >
    > In the previous implementation, functions overwrote any budget
    > decrements caused by recursive invocations of themselves, which
    > could cause tier-up decisions for certain unlucky functions to
    > get delayed unreasonably long.
    > This patch avoids this by working with the on-instance value
    > directly instead of caching it in a stack slot. That generates
    > the same amount of Liftoff code as the status quo, but handles
    > recursive functions properly.
    > The "barista3" benchmark's peak performance improves by almost 20%.
    >
    > Bug: v8:12281
    > Change-Id: I8b487a88da99c2d22e132f2cc72bdf36aa5f6e63
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3693710
    > Commit-Queue: Jakob Kummerow <jkummerow@chromium.org>
    > Reviewed-by: Clemens Backes <clemensb@chromium.org>
    > Cr-Commit-Position: refs/heads/main@{#81249}
    
    Bug: v8:12281, v8:12984
    Change-Id: Ie254236785628c07ac569de16ea82a67ed5bd221
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3714247
    Auto-Submit: Michael Achenbach <machenbach@chromium.org>
    Owners-Override: Michael Achenbach <machenbach@chromium.org>
    Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
    Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/main@{#81267}
    2864fd0f
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.style.yapf Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...