• Benedikt Meurer's avatar
    [turbofan] Refactor the JSCreateArray lowering to support more cases. · 279a83e4
    Benedikt Meurer authored
    Array (subclass) constructor calls with 0 parameters are now properly
    turned into inline allocations, also Array (subclass) constructor calls
    with exactly one parameter, which is either known to not be a Number
    or which is a known integer in the valid loop unrolling range.
    
    Also refactor the general JSCreateArray lowering logic to properly
    support Array subclasses, i.e. deal with inobject properties and
    initial maps correctly.
    
    This boosts performance of those cases significantly (and will allow
    us to reduce the complexity of the Array constructor significantly
    long-term). For example the simple case
    
      new Array("a", "b", "c", "d", "e", "f", "g")
    
    is now around 10x faster than before.
    
    Bug: v8:6399
    Change-Id: I70661971398524ee0c6a349ee559b98a962a6266
    Reviewed-on: https://chromium-review.googlesource.com/703134
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: 's avatarJaroslav Sevcik <jarin@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#48325}
    279a83e4
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...