• Andreas Haas's avatar
    Reland "[wasm][liftoff] Cache the memory start register" · 274aaaaf
    Andreas Haas authored
    On a loop back edge both the cached instance and the cached memory
    start have to get restored for the next loop iteration. In the original
    CL we did not consider the case that by restoring the instance we may
    overwrite the currently cached memory start.
    
    Original description:
    
    WebAssembly functions often have subsequent memory accesses, and each of
    these memory accesses need the start address of the memory in a register.
    With this CL the register with the memory start address is cached, so
    only the first memory access has to load the memory start address into a
    register, subsequent memory accesses can just reuse the register.
    
    In first measurements with the epic benchmark this reduces the size of
    the generated Liftoff code by a bit more than 5%.
    
    R=clemensb@chromium.org
    
    Bug: v8:11862
    Change-Id: I884c0da24be8bc6b10f2c6bf5437b9a279819538
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2960220Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
    Commit-Queue: Andreas Haas <ahaas@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#75183}
    274aaaaf
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...