• Shu-yu Guo's avatar
    [sandbox] Make external ptr table usable under pointer compression · 2679a36e
    Shu-yu Guo authored
    This CL moves the external pointer table out of V8_ENABLE_SANDBOX and
    into V8_COMPRESS_POINTERS. The external pointer table is also useful
    even when not sandboxing external pointers to ease alignment
    requirements under pointer compression.
    
    It is onerous for the allocator to support non-tagged-size alignment.
    Under pointer compression, tagged is 4 bytes while system pointers are
    8 bytes. Because external pointer table indices are 4-bytes, fields that
    require natural alignment (e.g. the state field in JSAtomicsMutex) when
    the system pointer size is 8-bytes can use an indirection via the
    pointer table to ease the alignment restriction back to 4-bytes under
    pointer compression.
    
    Bug: v8:10391
    Change-Id: Iac1200e40c987128cd6a227cd279ba4dac0e5c56
    Cq-Include-Trybots: luci.v8.try:v8_linux64_pointer_compression_rel_ng
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3783076Reviewed-by: 's avatarSamuel Groß <saelo@chromium.org>
    Commit-Queue: Shu-yu Guo <syg@chromium.org>
    Reviewed-by: 's avatarAdam Klein <adamk@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#81977}
    2679a36e
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.style.yapf Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...