• Benedikt Meurer's avatar
    [builtin] Further cleanup %ArrayIteratorPrototype%.next(). · 2650fc33
    Benedikt Meurer authored
    Refactor the ArrayIteratorPrototypeNext CSA builtin to handle the
    JSArray element access in a dedicated helper macro, very similar
    to how it's done for JSTypedArray's. Also add support for dictionary
    elements to this helper macro using the existing dictionary access
    logic in the CodeStubAssembler.
    
    This improves the readability of the builtin significantly and the
    performance of iterating arrays with dictionary elements goes up by
    a factor of ~3.5x.
    
    Bug: v8:8015, v8:8070
    Change-Id: Ibfee760ea1e4bc0fffb42b232fb1d097b706bd1f
    Reviewed-on: https://chromium-review.googlesource.com/1183305Reviewed-by: 's avatarJaroslav Sevcik <jarin@chromium.org>
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#55283}
    2650fc33
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...