• Milad Farazmand's avatar
    PPC/s390: [wasm][arm][arm64][liftoff] Allow loads from negative indices · 2638328d
    Milad Farazmand authored
    Port 4765c70f
    
    Original Commit Message:
    
        On arm, the root register points into the middle of the roots array to
        allow to use the full int12_t offset range. Therefore some offsets into
        the root array are negative. This CL changes the liftoff assembler for
        arm to allow loads from negative offsets.
    
        On arm64, offsets can also be negative when pointer compression is
        disabled.
    
        Additionally this CL changes the signature of
        LiftoffAssembler::LoadTaggedPointer from uint32_t to int32_t to allow
        the LiftoffCompiler to provide negative indices.
    
        This CL does not come with a separate test yet. However, this changes is
        needed for https://crrev.com/c/2352784. Where there will also be a test.
    
    R=ahaas@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com
    BUG=
    LOG=N
    
    Change-Id: Ie286b0169a5f7a1de90e0ec7002bfac83383ea6c
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2363127Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
    Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com>
    Cr-Commit-Position: refs/heads/master@{#69456}
    2638328d
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...