• Annie Sullivan's avatar
    Revert "[wasm] redirect wasm calls to js functions through a GCed table" · 25f03308
    Annie Sullivan authored
    This reverts commit eb65f35e.
    
    Reason for revert: Broke jetstream benchmark on android.
    
    BUG=chromium:750828
    
    Original change's description:
    > [wasm] redirect wasm calls to js functions through a GCed table
    > 
    > With this patch, rather than embedding the JSReceiver address directly
    > in the WasmToJS wrappers, we put that in a fixed array with global handle
    > scope and instead embed the location of the handle and the index in the
    > wrapper. This ensures that the wrapper doesn't need to be patched if the
    > GC kicks in. This is needed to get the WASM code off the GCed heap.
    > 
    > R=​mtrofin@chromium.org
    > 
    > Bug: 
    > Change-Id: Ie5a77a78cdecec51b04f702c63b8e4285e6a2d8d
    > Reviewed-on: https://chromium-review.googlesource.com/581682
    > Commit-Queue: Aseem Garg <aseemgarg@chromium.org>
    > Reviewed-by: Mircea Trofin <mtrofin@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#46884}
    
    TBR=mtrofin@chromium.org,aseemgarg@google.com,aseemgarg@chromium.org,clemensh@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Change-Id: I26f49ee0a1fe73cc5d8852ded87b56638be39ebf
    Reviewed-on: https://chromium-review.googlesource.com/596268
    Commit-Queue: Aseem Garg <aseemgarg@chromium.org>
    Reviewed-by: 's avatarClemens Hammacher <clemensh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#47059}
    25f03308
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...