• Michael Lippautz's avatar
    cppgc: Limit sweeping on allocation if possible · 25c6d74e
    Michael Lippautz authored
    Align slow path allocation with V8 in that:
    1. Try to refill from the free list.
    2. Perform limited sweeping of a space if necessary and retry the free
       list.
    3. Try to expand the space.
    4. Perform full sweeping of a space if necessary and retry the free
       list.
    5. Finish sweeping fully as we would anyways do a GC at this point.
    6. Retry the free list again
    7. Try expanding again as finishing sweeping may have freed up pages.
    
    Specifically, this adresses a performance problem where we would fully
    sweep the whole heap, possibly causing 100ms of jank on allocation. In
    such cases the new approach maintains performance and stays fast at the
    expense of using more memory.
    
    Allocations usually find memory in 1.-3. Steps 4.-7. are slow paths
    that are definitely expensive but prevent failing with OOM.
    
    Bug: v8:13294
    Change-Id: I56133fa4cbbc74f8abcdec49c7e10125c2dbc3e9
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3899260
    Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
    Reviewed-by: 's avatarOmer Katz <omerkatz@chromium.org>
    Reviewed-by: 's avatarAnton Bikineev <bikineev@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#83268}
    25c6d74e
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.style.yapf Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...