• Clemens Hammacher's avatar
    [Liftoff] Fix conditional spilling · 2589ea08
    Clemens Hammacher authored
    On float comparisons, we need a scratch byte register for the setcc
    instruction, and if none is available, we spill. But this spilling code
    is skipped if one of the operands is NaN. The cache state is updated
    however, so following code assumes that the spill happened.
    This CL fixes this by spilling before checking for NaN, such that the
    spilling code is always executed.
    
    R=titzer@chromium.org
    
    Bug: v8:7582, v8:6600
    Change-Id: I768d8de14e494d3ebea181c1f9f3129a4b005396
    Reviewed-on: https://chromium-review.googlesource.com/973961Reviewed-by: 's avatarBen Titzer <titzer@chromium.org>
    Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#52162}
    2589ea08
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...